Set record input props for all players, not just authority #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piler hits error if function doesnt exist, so typos are caught with static RPC functions)
TheYellowArchitect
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #250
Basically registers the properties in that variable. Otherwise, it is always the same as
_auth_input_propsand made obsolete by it. But it shouldn't be so, because_record_input_propsshouldn't care about authority, just like_record_state_props.Currently, without this PR, there is no way to get the input property entries of a
RollbackSynchronizerwhose authority we don't have. Which is illogical given we know its_inputs.Not to mention that this variable currently exists, but is completely unused (it cannot be used without this anyway)