-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dockerfile #47
Conversation
Will test it here: https://github.com/Ughuuu/noray/actions |
Ok, works and it generates a package of this form: https://github.com/Ughuuu/noray/pkgs/container/noray For this repo it will be docker pull ghcr.io/foxssake/noray:pr-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a review, some comments might not be relevant with the PR being a draft, but let me know!
Updated feedback. Locally seems ok, looks like it should work but you never know really unless you merge and it runs on main branch.(Changed that it only pushes on main branch docker and builds on both pr and main) You can enable the workflows to run also here to double check. |
Saw this happen also locally where e2e tests would hang, but I assumed it was from my frok of the repo. |
Can you rerun the e2e test please some times and see if it passes? Usually it should pass in 20s or so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, had some time to go through the PR in more detail. Added some minor comments, but I'm also happy to do the fixups if you invite me to the fork.
The e2e step seems to be struggling, let me look into it. |
FYI this will be a "chore" commit as it doesn't affect the main application logic. Please bump the patch component in package.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the feature and patience during the review process!
📓 Description
Adds docker build to this and exports the docker to GitHub packages so people can run it easier.
☑️ Checklist
Updated the README
🔗 Related issues
#46