Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate id's with custom length and letters #48

Merged

Conversation

Ughuuu
Copy link

@Ughuuu Ughuuu commented Nov 26, 2023

📓 Description

I want to be able to generate id's with smaller length(eg 4-5) and a shorter alphabet

☑️ Checklist

  • Documentation is up to date
  • [?] Versions are bumped as needed

🔗 Related issues

#44

@Ughuuu Ughuuu marked this pull request as draft November 26, 2023 12:44
@Ughuuu
Copy link
Author

Ughuuu commented Nov 26, 2023

Need to test it locally and build it, will wait for the docker change to be merged so it's easier to build.

Copy link

@elementbound elementbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some suggestions.

.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
src/hosts/host.entity.mjs Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
src/config.mjs Outdated Show resolved Hide resolved
src/config.mjs Outdated Show resolved Hide resolved
src/hosts/host.entity.mjs Outdated Show resolved Hide resolved
@elementbound
Copy link

FYI this will be a "feat" commit as it adds a new feature. Please bump the minor component in package.json.

@Ughuuu Ughuuu marked this pull request as ready for review November 27, 2023 19:53
.env.example Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/hosts/host.entity.mjs Outdated Show resolved Hide resolved
Copy link

@elementbound elementbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for bearing with the comments!

@elementbound elementbound merged commit e01f8e7 into foxssake:main Nov 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants