Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widescreen logs #38

Closed
wants to merge 3 commits into from
Closed

Widescreen logs #38

wants to merge 3 commits into from

Conversation

TriMoon
Copy link
Contributor

@TriMoon TriMoon commented Oct 21, 2023

Adjusted Logs screen to display properly on a widescreen also.

  • Changed header into 2 lines to better group the info.
  • Added border radius on header for visual.
  • Changed header background for visual.
  • Added odd/even background changes to differentiate different lines.

My widescreen:
FoxyProxy-extension-Widescreen logs


Responsive design, vertical:
FoxyProxy-extension-Widescreen logs2

Signed-off-by: TriMoon (GitHub) <TriMoon@users.noreply.github.com>
Adjusted Logs screen to display properly on a widescreen also.
- Changed header into 2 lines to better group the info.
- Added border radius on header for visual.
- Changed header background for visual.
- Added odd/even background changes to differentiate different lines.

Signed-off-by: TriMoon (GitHub) <TriMoon@users.noreply.github.com>
Signed-off-by: TriMoon (GitHub) <TriMoon@users.noreply.github.com>
@TriMoon
Copy link
Contributor Author

TriMoon commented Oct 22, 2023

Just a request, could you guys add a button on the popup to directly open the logs view like we have on the old version? 🤝
I wasn't able to do it because i'm too unfamiliar with the JS code, in particular i went as far as just adding the button on the popup and opening the options page but i didn't know how to make the button open the view directly...

@erosman
Copy link
Collaborator

erosman commented Oct 22, 2023

Please note:

  • colors must be set for both light & dark schemes
  • CSS nesting is not supported on older Firefox before 117 and it is still getting completed

Full width log is done.

@TriMoon
Copy link
Contributor Author

TriMoon commented Oct 22, 2023

  • CSS nesting is not supported on older Firefox before 117 and it is still getting completed

I don't think that will be a problem because:

  1. The older FoxyProxy can be used for those older versions.
  2. The current Firefox-snap version is 119.0b9 which most people use by default.
  3. Development of this new software should embrace current implemented features if it can benefit from it.
  4. The manifest should of-course be updated to reflect this minimum version in this case 👍
  • colors must be set for both light & dark schemes

I will leave that to you (to add after merging this PR) 😉

Full width log is done.

Does that mean you already implemented it in another way as this PR? 🤔
Take notice that i also modified the column widths etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants