Correct auth for same proxy address #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. If such a previous decision is not found, repeat the selection process.
- we know what proxy should be used, - this corresponds with the proxy used (host and port) and - we have a username or password to give away. Keep the "authPending" logic.
tracking object proxy_for_requestID
…ntials used for authentication. We get this info from proxy_for_requestID, based on the url/address from the actual host via function proxyRequest (from cache or directly).
proxy_for_requestID . No need for this special cache anymore.
To stop computing content of authData here, was the goal of this patch series. It stored credentials only for the last proxy configuration with the same proxy address and "forgot" earlier configurations. Disabled proxies were not sorted out, different ports were ignored In case of different proxy configurations with the same address, always the same username and password (from the last configuration) was used.
|
The process has changed in FoxyProxy v8.0 (once released). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.