Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use prettyprinter #148

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

michaelpj
Copy link
Contributor

ansi-wl-pprint is deprecated in favour of prettyprinter.

Why do I care about this? The answer is somewhat annoying:

  • optparse-applicative and ansi-wl-pprint interoperate nicely unless you get a specific combination of versions, namely an old ansi-wl-pprint (before it switched to prettyprinter) and a new optparse-applicative (after it switched to prettyprinter). This can manifest for example in turtle
  • inline-c is what is causing me to pull in an old ansi-wl-pprint, so I figured I could also just try and fix that :)

`ansi-wl-pprint` is deprecated in favour of `prettyprinter`.
@hololeap
Copy link

I just want to point out that I'm getting an error when building the tests:

test/Language/C/Types/ParseSpec.hs:18:1: error:
    Could not load module ‘Text.PrettyPrint.ANSI.Leijen’
    It is a member of the hidden package ‘ansi-wl-pprint-1.0.2’.
    Perhaps you need to add ‘ansi-wl-pprint’ to the build-depends in your .cabal file.
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
18 | import qualified Text.PrettyPrint.ANSI.Leijen as PP
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thanks for working on this.

@michaelpj
Copy link
Contributor Author

Thanks, not sure how I missed that! Tests build and pass now.

@alaendle
Copy link

Could this please be merged/released? With this in place also inline-c (and dependents) will find there way back to stackage (I've tested against nightly-2023-09-21).

@bitonic
Copy link
Collaborator

bitonic commented Sep 21, 2023

Sorry about the delay -- I've been pretty busy with other stuff. Will merge and release.

@bitonic bitonic merged commit 318901b into fpco:master Sep 21, 2023
@alaendle
Copy link

Many thanks 👍 and sorry if I sounded harsh. There is absolute no reason to apologize (we all value open source work and know that it is hard)! I just wanted to add a statement, that this PR would indeed improve things and should be considered with priority. Not more, not less 😉

@bitonic
Copy link
Collaborator

bitonic commented Sep 21, 2023

Released as https://hackage.haskell.org/package/inline-c-0.9.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants