Ability to optionally log #1
Conversation
| loop { | ||
| for signal in signals.pending() { | ||
| for signal in signals.forever() { |
There was a problem hiding this comment.
This fixes the busy loop issue. Earlier the above loop caused 100% cpu consumption.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| let pid = u32::try_from(pid.as_raw()).ok()?; | ||
| if pid == child { | ||
| graceful_shutdown() |
There was a problem hiding this comment.
Calling the abort call previously resulted in the segmentation fault issue.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| } | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
Sample program to test that it does reap the orphan process.
| let exit_status = ExitStatus { | ||
| pid, | ||
| // Translate signal to exit code | ||
| exit_code: signal as i32 + 128, |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
The process can exit because of two reasons:
- Normal exit
- Exit via Unix signals
In case of Unix signals, we remap it to proper exit code.
There was a problem hiding this comment.
I get that, but you seem to be conflating the process ID and the exit status.
There was a problem hiding this comment.
Do you think renaming it from ExitStatus to ProcessStatus will be helpful ?
There was a problem hiding this comment.
Can you look over the code one more time from scratch? I think you'll see what I'm talking about: in some branches you're returning a process ID, in some an exit code, and in some a signal, but assigning all of them to a variable called pid.
There was a problem hiding this comment.
I have gone ahead with some renaming which will hopefully help with the confusion.
There was a problem hiding this comment.
Can you look over the code one more time from scratch? I think you'll see what I'm talking about: in some branches you're returning a process ID, in some an exit code, and in some a signal, but assigning all of them to a variable called pid.
Sure, I will let you know once it's ready for review. Thanks!
There was a problem hiding this comment.
Never mind, I see my confusion, you were completely correct. Sorry for the noise.
src/lib.rs
Outdated
| @@ -50,10 +81,12 @@ fn pid1_handling(child: Option<Child>) -> ! { | |||
| }; | |||
| (|| { | |||
| let child = child?; | |||
| let pid = pid?; | |||
| let child_exit_status = pid?; | |||
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry for the confusing name, I have renamed it. Can you see if that helps ?
By default it doesn't log. This also fixes the segmentation fault issue that was happening before.