Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ignore_* and skip_* options #572

Closed
mkniewallner opened this issue Mar 7, 2024 · 0 comments · Fixed by #596
Closed

Remove deprecated ignore_* and skip_* options #572

mkniewallner opened this issue Mar 7, 2024 · 0 comments · Fixed by #596
Assignees
Labels
breaking Change that introduces a breaking change enhancement New feature or request
Milestone

Comments

@mkniewallner
Copy link
Collaborator

ignore_* and skip_* options have been deprecated in 0.12.0, with warnings about their deprecation and replacements. We could completely remove them in a new minor release, since we are still using 0.x versioning scheme.

This would effectively remove the following options:

  • with replacements in [tool.deptry]:
    • ignore_misplaced-dev -> replaced with ignore = ["DEP004"]
    • ignore_missing -> replaced with ignore = ["DEP001"]
    • ignore_obsolete -> replaced with ignore = ["DEP002"]
    • ignore_transitive -> replaced with ignore = ["DEP003"]
    • ignore_unused -> replaced with ignore = ["DEP002"]
  • with replacements in [tool.deptry.per_rule_ignores]:
    • skip_misplaced_dev -> replaced with DEP004 = ["dep", ...]
    • skip_missing -> replaced with DEP001 = ["dep", ...]
    • skip_obsolete -> replaced with DEP002 = ["dep", ...]
    • skip_transitive -> replaced with DEP003 = ["dep", ...]
    • skip_unused -> replaced with DEP002 = ["dep", ...]

In order to facilitate the removal of those options, #571 would be really nice to have, as without it, removed options that are still set in [tool.poetry] will be ignored instead of raising an error.

@mkniewallner mkniewallner added the enhancement New feature or request label Mar 7, 2024
@mkniewallner mkniewallner added this to the 0.14 milestone Mar 7, 2024
@mkniewallner mkniewallner pinned this issue Mar 7, 2024
@mkniewallner mkniewallner modified the milestones: 0.14, 0.15 Mar 14, 2024
@mkniewallner mkniewallner self-assigned this Mar 15, 2024
@mkniewallner mkniewallner changed the title Remove deprecated ignore_* and skip_ options Remove deprecated ignore_* and skip_* options Mar 15, 2024
@mkniewallner mkniewallner added the breaking Change that introduces a breaking change label Mar 18, 2024
@mkniewallner mkniewallner unpinned this issue Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change that introduces a breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant