Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): detect invalid pyproject.toml options #571

Merged

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Mar 6, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Detect invalid configuration options set in [tool.deptry] section of pyproject.toml based on the list of existing arguments in the CLI. This will facilitate the removal of deprecated options, since currently, invalid options do not throw any runtime error, so if we end up removing options we have deprecated, the now gone options would just be ignored instead of throwing an error.

@mkniewallner mkniewallner force-pushed the feat/detect-invalid-options branch from eafe7fd to 61410a2 Compare March 6, 2024 23:59
@mkniewallner mkniewallner added this to the 0.13 milestone Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.5%. Comparing base (503d884) to head (21d27dd).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #571   +/-   ##
=====================================
  Coverage   90.4%   90.5%           
=====================================
  Files         39      39           
  Lines       1084    1095   +11     
  Branches     220     222    +2     
=====================================
+ Hits         980     991   +11     
  Misses        89      89           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner force-pushed the feat/detect-invalid-options branch from 61410a2 to 13bd668 Compare March 7, 2024 19:12
@mkniewallner mkniewallner marked this pull request as ready for review March 7, 2024 19:19
@mkniewallner mkniewallner requested a review from fpgmaas March 7, 2024 19:22
@mkniewallner mkniewallner force-pushed the feat/detect-invalid-options branch from 13bd668 to 21d27dd Compare March 9, 2024 12:50
@mkniewallner mkniewallner enabled auto-merge (squash) March 9, 2024 12:50
@mkniewallner mkniewallner merged commit 7c7a995 into fpgmaas:main Mar 9, 2024
19 checks passed
@mkniewallner mkniewallner deleted the feat/detect-invalid-options branch March 24, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants