-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11 #152
Conversation
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=======================================
+ Coverage 92.2% 92.9% +0.7%
=======================================
Files 42 43 +1
Lines 1348 1357 +9
=======================================
+ Hits 1243 1261 +18
+ Misses 105 96 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mkniewallner For Here is the failed CI/CD pipeline, and here is the pipeline that ran successfully directly before it. But let's see if the issue is solved with |
Maybe bumping to |
Resolves #63.
PR Checklist
docs
is updatedDescription of changes
Add support for Python 3.11, refactoring a tiny bit the method importing stdlib along the way, and enable tests on the CI.
cf3ada0 also slightly updates the CI to provide faster feedback to users, by removing
fail-fast
in order to run all tests, in case tests fail on multiple versions, and removingneeds
when not strictly needed.I noticed that
3.11
was added then removed because of a random issue. We had the same issue on Poetry, but only on macOS, and had a workaround for it. Since we don't use macOS on the CI indeptry
, there's some chance that the issue only happens on macOS on more recent Python 3.11 (we now are at rc2, whereas the previous failures happened on beta5), so I'd suggest that we re-add tests and see if we still notice a failure. If we do, we can apply the same fix that was made on Poetry.Just so you know,
3.11-dev
foractions/setup-python
means "latest 3.11 version, including alphas/betas", as per the documentation. So once3.11.0
final is released and available, it will automatically be selected.