Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved issue with importing from local files #163

Merged
merged 3 commits into from
Oct 22, 2022
Merged

solved issue with importing from local files #163

merged 3 commits into from
Oct 22, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Oct 22, 2022

There was an issue with imports from files in same directory begin marked as missing dependencies. For example, consider the following directory:

  dir
   - foo.py
   - bar.py

In this case, if foo.py any imports from bar.py such as 'from bar import x', this resulted in an error, since the module bar is not found in the installed modules. This MR solves that issue.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@codecov-commenter
Copy link

Codecov Report

Merging #163 (22f5bae) into main (7659a91) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #163   +/-   ##
=====================================
  Coverage   95.1%   95.1%           
=====================================
  Files         28      28           
  Lines        882     895   +13     
  Branches     133     136    +3     
=====================================
+ Hits         839     852   +13     
  Misses        28      28           
  Partials      15      15           
Impacted Files Coverage Δ
deptry/import_parser.py 96.0% <100.0%> (+0.4%) ⬆️
deptry/compat.py 57.1% <0.0%> (ø)
deptry/core.py 97.3% <0.0%> (+<0.1%) ⬆️
deptry/dependency_getter/base.py 95.0% <0.0%> (+0.2%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas merged commit 0c42bd0 into main Oct 22, 2022
@fpgmaas fpgmaas deleted the local_imports branch October 22, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants