Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Python version to cache key #173

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

https://github.com/fpgmaas/deptry/actions/runs/3320886881/jobs/5487809759#step:4:20 highlights that we are currently running tox under Python 3.10 regardless of the Python version sent as an input, because we share the cache key regardless of the version.

@mkniewallner mkniewallner requested a review from fpgmaas November 5, 2022 23:24
@codecov-commenter
Copy link

Codecov Report

Merging #173 (06a634b) into main (6f54023) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #173   +/-   ##
=====================================
  Coverage   95.1%   95.1%           
=====================================
  Files         28      28           
  Lines        895     895           
  Branches     146     136   -10     
=====================================
  Hits         852     852           
  Misses        28      28           
  Partials      15      15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner merged commit 210a5c0 into fpgmaas:main Nov 6, 2022
@mkniewallner mkniewallner deleted the ci/fix-python-tox branch November 6, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants