Add pyupgrade to pre-commit
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
commented
Nov 5, 2022
| @@ -27,7 +27,7 @@ def extract(self, path_to_ipynb: Path) -> List[str]: | |||
|
|
|||
| @staticmethod | |||
| def _read_ipynb_file(path_to_ipynb: Path) -> Dict[str, Any]: | |||
| with open(path_to_ipynb, "r") as f: | |||
| with open(path_to_ipynb) as f: | |||
There was a problem hiding this comment.
| @@ -93,7 +93,7 @@ def test_cli_with_json_output(dir_with_venv_installed): | |||
|
|
|||
| # assert that there is json output | |||
| subprocess.run(shlex.split("poetry run deptry . -o deptry.json"), capture_output=True, text=True) | |||
| with open("deptry.json", "r") as f: | |||
| with open("deptry.json") as f: | |||
There was a problem hiding this comment.
| @@ -8,7 +8,7 @@ def test_simple(tmp_path): | |||
| with run_within_dir(tmp_path): | |||
| JsonWriter(json_output="output.json").write(issues={"one": "two", "three": "four"}) | |||
|
|
|||
| with open("output.json", "r") as f: | |||
| with open("output.json") as f: | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
=====================================
Coverage 95.1% 95.1%
=====================================
Files 28 28
Lines 895 895
Branches 136 136
=====================================
Hits 852 852
Misses 28 28
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mkniewallner
force-pushed
the
chore/add-pyupgrade
branch
from
9cd2e41 to
a4d21cf
Compare
fpgmaas
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Add https://github.com/asottile/pyupgrade/ to our pre-commit hooks.
The library rewrites code to newer syntax of Python versions, which will prove useful the day we drop support for Python 3.7.
A nice feature of
pyupgradeis also https://github.com/asottile/pyupgrade/#python2-and-old-python3x-blocks, which will rewrite a conditional import whenever the Python version in the condition is not supported anymore.