Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and simplify CI configuration and fix 3.11 random failures #192

Merged
merged 12 commits into from
Nov 14, 2022

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Nov 13, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

This quite big PR updates the CI configuration in order to simplify it, reduce the workflow duration and more efficiently use the cache. The main changes are:

  • fix 3.11 flaky tests in f1140a4 by upgrading pip (example / fixed by Bad metadata: TypeError: expected string or bytes-like object, got 'NoneType' pypa/pip#11352)
  • remove unneeded Poetry environment install in e7eed26 and properly set up cache for tox (right now we install dependencies twice, with the second one always being uncached)
  • simplify local environment by running all commands through Poetry rather than requiring to get into a shell via poetry shell or a source command in 478359b
  • remove unneeded options in install-poetry, as they are already the default
  • remove duplicated steps in on-release-main workflow in 2d2ea52 (they are technically already run each time we push to main, so IMO it's not really needed to run them each time we tag a new release)
  • move docs dependencies into the main pyproject.toml in acca4cf, making the setup easier locally as users will only have one install to do for all dependencies
  • remove duplicated steps in quality job in f27a179, as mypy and pytest are already run in tox
  • cache pre-commit dependencies in c230698, to avoid re-installing them on each job run if .pre-commit-config.yaml didn't change

In terms of duration:

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #192 (c230698) into main (e34e72e) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #192   +/-   ##
=====================================
  Coverage   95.5%   95.5%           
=====================================
  Files         29      29           
  Lines        920     920           
  Branches     139     207   +68     
=====================================
  Hits         879     879           
  Misses        27      27           
  Partials      14      14           
Impacted Files Coverage Δ
deptry/utils.py 90.9% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review November 13, 2022 21:18
@mkniewallner mkniewallner requested a review from fpgmaas November 13, 2022 21:18
@fpgmaas
Copy link
Owner

fpgmaas commented Nov 14, 2022

Wow, great work! This is a major improvement to the CI/CD Pipeline. Also nice that we finally get rid of the separate environment for the documentation.. That was a bit of an ugly work-around for some dependency conflicts that I could not be bothered to resolve in the early stages of development.

@mkniewallner mkniewallner force-pushed the ci/bunch-of-improvements branch from c230698 to 6a7b320 Compare November 14, 2022 13:52
@fpgmaas fpgmaas merged commit 5b1bce6 into fpgmaas:main Nov 14, 2022
@mkniewallner mkniewallner deleted the ci/bunch-of-improvements branch November 14, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants