Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to NotebookImportExtractor to guess the encoding on initi… #216

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented Nov 21, 2022

…al UnicodeDecodeError

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@fpgmaas fpgmaas requested a review from mkniewallner November 21, 2022 12:51
@fpgmaas fpgmaas linked an issue Nov 21, 2022 that may be closed by this pull request
Copy link
Collaborator

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but non-blockers, so approving.

fpgmaas and others added 2 commits November 22, 2022 14:14
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
@fpgmaas
Copy link
Owner Author

fpgmaas commented Nov 22, 2022

Some nits, but non-blockers, so approving.

Thanks for reviewing!

@codecov-commenter
Copy link

Codecov Report

Merging #216 (77c229c) into main (ea7ba57) will decrease coverage by 0.5%.
The diff coverage is 75.0%.

@@           Coverage Diff           @@
##            main    #216     +/-   ##
=======================================
- Coverage   96.2%   95.7%   -0.6%     
=======================================
  Files         31      31             
  Lines        897     907     +10     
  Branches     201     203      +2     
=======================================
+ Hits         863     868      +5     
- Misses        22      26      +4     
- Partials      12      13      +1     
Impacted Files Coverage Δ
...ptry/imports/extractors/python_import_extractor.py 100.0% <ø> (ø)
...ry/imports/extractors/notebook_import_extractor.py 88.0% <66.6%> (-12.0%) ⬇️
deptry/imports/extractors/base.py 96.0% <100.0%> (+1.0%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fpgmaas fpgmaas merged commit 2823be6 into main Nov 22, 2022
@fpgmaas fpgmaas deleted the 215-ipynb-encoding branch November 22, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deptry fails opening ipynb files
3 participants