Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move renovate-config-validator to GH Actions #233

Merged

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Dec 11, 2022

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Most of the contributors won't ever update renovate configuration, yet the pre-commit hook takes quite some time to install locally (at least for me).

So instead of running it through pre-commit, this PR moves the workflow to a dedicated GitHub Actions workflow, similarly to the one we have for codecov configuration.

The PR also updates the schedule for lock file maintenance, so it runs on Saturday, same as the other updates, instead of Monday (which also allows validating the changes in the PR, to confirm that the workflow works correctly).

@codecov-commenter
Copy link

Codecov Report

Merging #233 (a82c018) into main (093e55c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #233   +/-   ##
=====================================
  Coverage   95.7%   95.7%           
=====================================
  Files         32      32           
  Lines        914     914           
  Branches     203     203           
=====================================
  Hits         875     875           
  Misses        26      26           
  Partials      13      13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review December 11, 2022 17:13
@mkniewallner mkniewallner requested a review from fpgmaas December 11, 2022 17:13
@mkniewallner mkniewallner merged commit 7493cb8 into fpgmaas:main Dec 11, 2022
@mkniewallner mkniewallner deleted the chore/move-renovate-config-validator branch December 11, 2022 17:31
@fpgmaas fpgmaas mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants