Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tox workflow #241

Merged
merged 4 commits into from
Dec 24, 2022
Merged

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

tox workflow is currently broken because we don't pin a specific version of tox-gh-actions, and a new major version was released yesterday (https://github.com/ymyzk/tox-gh-actions/releases/tag/v3.0.0).

This made us automatically pick up tox>=4, which removed whitelist_externals option in favour of allowlist_externals (https://github.com/tox-dev/tox/releases/tag/4.0.0rc4).

So the PR updates the parameter used, and updates the installation of tox-gh-actions to pin a specific version, as well as hinting Renovate on it, so we can still benefit from regular updates while facilitating build reproducibility.

It also removes the installation of tox which is useless, as tox-gh-actions already depend on one specific major version of tox. We can even see in the previously working build that we installed 4.x.y, but then went back to 3.x.y because tox-gh-actions<3 didn't accept tox>=4.

@mkniewallner mkniewallner marked this pull request as ready for review December 24, 2022 13:18
@codecov-commenter
Copy link

Codecov Report

Merging #241 (945d285) into main (7f4dc05) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #241   +/-   ##
=====================================
  Coverage   95.7%   95.7%           
=====================================
  Files         32      32           
  Lines        914     914           
  Branches     203     203           
=====================================
  Hits         875     875           
  Misses        26      26           
  Partials      13      13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner requested a review from fpgmaas December 24, 2022 13:18
@mkniewallner mkniewallner merged commit 0d07303 into fpgmaas:main Dec 24, 2022
@mkniewallner mkniewallner deleted the ci/fix-tox-workflow branch December 24, 2022 16:04
@fpgmaas fpgmaas mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants