Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files from .gitignore #248

Merged
merged 8 commits into from
Dec 30, 2022

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Dec 30, 2022

Resolves #200.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

This PR implements the changes suggested in the linked issue with the help of pathspec, with a slight modification: it doesn't empty the default exclude list. Since not all projects use git, I figured that it might be better to keep this default list.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #248 (0991b01) into main (01f6b83) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #248   +/-   ##
=====================================
  Coverage   95.6%   95.7%           
=====================================
  Files         32      32           
  Lines        899     919   +20     
  Branches     189     192    +3     
=====================================
+ Hits         860     880   +20     
  Misses        26      26           
  Partials      13      13           
Impacted Files Coverage Δ
deptry/cli.py 93.4% <100.0%> (+0.1%) ⬆️
deptry/core.py 97.6% <100.0%> (+<0.1%) ⬆️
deptry/python_file_finder.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mkniewallner mkniewallner force-pushed the feat/ignore-from-gitignore branch from ebe114f to 0991b01 Compare December 30, 2022 14:04
@mkniewallner mkniewallner marked this pull request as ready for review December 30, 2022 14:04
@mkniewallner mkniewallner requested a review from fpgmaas December 30, 2022 14:04
@mkniewallner mkniewallner merged commit 426aec9 into fpgmaas:main Dec 30, 2022
@mkniewallner mkniewallner deleted the feat/ignore-from-gitignore branch January 2, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude files from .gitignore
3 participants