Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude some lines from coverage #338

Merged
merged 2 commits into from
Apr 23, 2023
Merged

exclude some lines from coverage #338

merged 2 commits into from
Apr 23, 2023

Conversation

akeeman
Copy link
Contributor

@akeeman akeeman commented Apr 21, 2023

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

I noticed that a test fails in #333 due to a coverage delta being too negative. It is induced by if TYPE_CHECKING: blocks, which should be ok.
This PR suggests some lines of code that may be excluded from coverage, as they generally are not ment to. It's a subset of what's suggested to be a good default by the covdefaults library.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #338 (dd960f9) into main (2f39fb5) will increase coverage by 4.1%.
The diff coverage is n/a.

❗ Current head dd960f9 differs from pull request most recent head d8c67e5. Consider uploading reports for the commit d8c67e5 to get more accurate results

@@           Coverage Diff           @@
##            main    #338     +/-   ##
=======================================
+ Coverage   91.8%   95.9%   +4.1%     
=======================================
  Files         29      29             
  Lines        955     914     -41     
  Branches     201     185     -16     
=======================================
  Hits         877     877             
+ Misses        50      24     -26     
+ Partials      28      13     -15     

see 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pyproject.toml Show resolved Hide resolved
@mkniewallner mkniewallner merged commit 3c61806 into fpgmaas:main Apr 23, 2023
@akeeman akeeman deleted the patch-3 branch April 23, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants