Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored issues and issue finders to include their error codes more clearly #401

Merged
merged 5 commits into from
May 17, 2023

Conversation

fpgmaas
Copy link
Owner

@fpgmaas fpgmaas commented May 15, 2023

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Curious for your thoughts!

@fpgmaas fpgmaas requested a review from mkniewallner May 15, 2023 08:17
@fpgmaas fpgmaas marked this pull request as draft May 15, 2023 08:17
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #401 (7c49c2f) into main (3621144) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #401     +/-   ##
=======================================
- Coverage   96.1%   96.1%   -0.1%     
=======================================
  Files         38      37      -1     
  Lines       1072    1070      -2     
  Branches     215     215             
=======================================
- Hits        1031    1029      -2     
  Misses        25      25             
  Partials      16      16             
Impacted Files Coverage Δ
deptry/core.py 98.0% <100.0%> (-0.1%) ⬇️
deptry/violations/__init__.py 100.0% <100.0%> (ø)
deptry/violations/base.py 100.0% <100.0%> (ø)
deptry/violations/dep001_missing/finder.py 100.0% <100.0%> (ø)
deptry/violations/dep001_missing/violation.py 100.0% <100.0%> (ø)
deptry/violations/dep002_unused/finder.py 93.5% <100.0%> (ø)
deptry/violations/dep002_unused/violation.py 100.0% <100.0%> (ø)
deptry/violations/dep003_transitive/finder.py 88.4% <100.0%> (ø)
deptry/violations/dep003_transitive/violation.py 100.0% <100.0%> (ø)
deptry/violations/dep004_misplaced_dev/finder.py 89.1% <100.0%> (ø)
... and 1 more

@fpgmaas fpgmaas marked this pull request as ready for review May 15, 2023 13:00
@fpgmaas fpgmaas force-pushed the refactor/issues branch from 821a032 to 4967dae Compare May 16, 2023 20:05
@fpgmaas fpgmaas merged commit 3ea80a6 into main May 17, 2023
@fpgmaas fpgmaas deleted the refactor/issues branch May 17, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants