fix(dependency_getter): stricten URL guessing #570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #539.
PR Checklist
Documentation indocs
is updatedDescription of changes
This strictens URL guessing when parsing
requirements.txt
format files by usingurllib.parse.urlparse
. At some point it would be nice to leverage parsing of dependencies to https://pypi.org/project/packaging/, although the library does not support legacy URL formats that AFAIK are still supported bypip
, despite not being recommended anymore. I have a draft PR for this in mkniewallner#29 that I should someday finish.