-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename requirements-txt
and requirements-txt-dev
#609
Conversation
… and requirements-file-dev
c50b823
to
9553dd1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
+ Coverage 90.7% 91.3% +0.5%
=======================================
Files 33 34 +1
Lines 986 996 +10
Branches 198 202 +4
=======================================
+ Hits 895 910 +15
+ Misses 74 69 -5
Partials 17 17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nit comments, but this mostly looks good to me. Just wondering if we should not name the parameters requirements-files
and requirements-files-dev
since they are lists.
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Good idea. I was doubting about this a bit, since |
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Rename
requirements-txt
andrequirements-txt-dev
torequirements-file
andrequirements-file-dev
PR Checklist
docs
is updatedDescription of changes
This PR proposes to rename
requirements-txt
andrequirements-txt-dev
torequirements-files
andrequirements-files-dev
. If users still use the old parameters, they will be shown a deprecation warning: