-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support imports using importlib.import_module
#782
Conversation
…el package (e.g. `http.server` -> `http`)
Added extra tests and made sure it works with all possible ways of aliasing the Ready for review @mkniewallner 😃 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
=====================================
Coverage 93.0% 93.0%
=====================================
Files 37 37
Lines 961 961
Branches 173 173
=====================================
Hits 894 894
Misses 51 51
Partials 16 16 ☔ View full report in Codecov by Sentry. |
…strings (`handle_import`, `handle_import_from`, `handle_expr`)
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
…docs/usage.md Co-authored-by: Mathieu Kniewallner <mathieu.kniewallner@gmail.com>
Thanks for the review @mkniewallner and @fpgmaas, refactors and nits addressed. I hope these new docstrings are sufficiently clear, but any further feedback welcome 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Commits:
if let
statements inStmt::Expr
match armimportlib
import are supportedPR Checklist
docs
is updatedDescription of changes
importlib.import_module
Dependencies with
importlib.import_module
are not detected #780