Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix DEP003 example by explicitly adding certifi #796

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

huisman
Copy link
Contributor

@huisman huisman commented Aug 7, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes
The example in the documentation for DEP003: transitive dependencies mentions explicitly adding certifi to the dependencies as the solution.
However (and confusingly) in the toml code example the package httpcore is added.
This PR makes sure the example toml code matches the written instructions by replacing httpcore in the example with certifi.

Explicitly add 'certifi'  in the transitive dependency example as instructed by the documentation instead of adding 'httpcore'.
Copy link
Collaborator

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@mkniewallner mkniewallner enabled auto-merge (squash) August 7, 2024 18:06
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.0%. Comparing base (4f20d7f) to head (c562502).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #796   +/-   ##
=====================================
  Coverage   93.0%   93.0%           
=====================================
  Files         37      37           
  Lines        961     961           
  Branches     173     173           
=====================================
  Hits         894     894           
  Misses        51      51           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner merged commit 4b6f210 into fpgmaas:main Aug 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants