Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve functional tests #921

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Oct 26, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

Bunch of improvements on functional tests, the main one being that we now depend on exact versions for dependencies, to improve a bit build reproducibility. Windows PyPy 3.10 have been randomly failing, so if we are lucky, this might help on that front.

@mkniewallner mkniewallner force-pushed the test/functional-tests-perf-improvement branch from 75001f9 to ee4b055 Compare October 26, 2024 14:02
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.6%. Comparing base (b8e1882) to head (960be45).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #921   +/-   ##
=====================================
  Coverage   92.6%   92.6%           
=====================================
  Files         37      37           
  Lines       1006    1006           
  Branches      99      99           
=====================================
  Hits         932     932           
  Misses        59      59           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner force-pushed the test/functional-tests-perf-improvement branch 3 times, most recently from 98bc1e9 to 38d8547 Compare October 26, 2024 15:00
@mkniewallner mkniewallner marked this pull request as ready for review October 29, 2024 12:43
@mkniewallner mkniewallner force-pushed the test/functional-tests-perf-improvement branch from 38d8547 to 960be45 Compare October 29, 2024 12:43
@mkniewallner
Copy link
Collaborator Author

Merging this one because I have the feeling this could solve the failing Windows PyPy 3.10 tests, and I'm tired of the failure 😄

@mkniewallner mkniewallner merged commit d9a1ba1 into main Oct 29, 2024
22 checks passed
@mkniewallner mkniewallner deleted the test/functional-tests-perf-improvement branch October 29, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant