-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pep621): use packaging
-based PEP 508 parser
#925
feat(pep621): use packaging
-based PEP 508 parser
#925
Conversation
packaging
-based PEP 508 parser
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
=======================================
+ Coverage 92.7% 93.0% +0.2%
=======================================
Files 37 37
Lines 992 991 -1
Branches 98 97 -1
=======================================
+ Hits 920 922 +2
+ Misses 56 55 -1
+ Partials 16 14 -2 ☔ View full report in Codecov by Sentry. |
67ef35d
to
591ffd4
Compare
@@ -15,7 +15,7 @@ def test_dependency_getter(tmp_path: Path) -> None: | |||
"qux", | |||
"bar>=20.9", | |||
"optional-foo[option]>=0.12.11", | |||
"conditional-bar>=1.1.0; python_version < 3.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never valid in the first place.
736d52e
to
2aa3979
Compare
2aa3979
to
a3a1311
Compare
a3a1311
to
d996cc6
Compare
Closes #735.
PR Checklist
docs
is updatedDescription of changes
In #913, we've changed the way we parse dependencies from requirements by switching to
requirements-parser
. This partly replaces what was done in #735.Since the dependency we added itself depends on
packaging
, we can leverage it to parse dependencies defined in PEP 621, without adding a new dependency.