Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency_getter): handle strings for setuptools dynamic dependencies #945

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mkniewallner
Copy link
Collaborator

Closes #944.

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

It might not be obvious from setuptools documentation, but file attribute can either be a string or a list of strings.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.0%. Comparing base (40765df) to head (4cab592).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #945   +/-   ##
=====================================
  Coverage   93.0%   93.0%           
=====================================
  Files         37      37           
  Lines        991     994    +3     
  Branches      97      98    +1     
=====================================
+ Hits         922     925    +3     
  Misses        55      55           
  Partials      14      14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner force-pushed the fix/handle-strings-setuptools-dynamic branch from 88965d5 to 4cab592 Compare November 15, 2024 21:53
@mkniewallner mkniewallner marked this pull request as ready for review November 15, 2024 21:57
@mkniewallner mkniewallner merged commit 2a9da88 into main Nov 15, 2024
22 checks passed
@mkniewallner mkniewallner deleted the fix/handle-strings-setuptools-dynamic branch November 15, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic still failing in pyproject.toml
1 participant