Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare build deps in pyproject.toml #258

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 17, 2023

... and remove Cython from the runtime dependencies (install_requires); it is only needed at build time.

@malb
Copy link
Collaborator

malb commented Oct 17, 2023

LGTM

@malb malb merged commit 21123b5 into fplll:master Oct 17, 2023
37 checks passed
@malb
Copy link
Collaborator

malb commented Oct 18, 2023

Should I cut a new release, i.e. would that make Sage packaging easier?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2023

No need

@mkoeppe mkoeppe deleted the pyproject_toml branch October 25, 2023 23:11
@dimpase
Copy link

dimpase commented Jan 20, 2024

Please make a new release (on PyPI too), as I just saw pip install fpyll (i.e. pulling version 0.6.0 from PyPI) and up to date python 3.10 venv with latest Cython, setuptools, etc, erroring out with

ModuleNotFoundError: No module named 'Cython'

Installing from master branch, i.e. pip install git+ssh://git@github.com/fplll/fpylll.git, worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants