Fix example commands in HelloWorld.html #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
approved these changes
Jan 10, 2024
|
Sorry for the late review, thank you for making this change! |
thomas-bc
added a commit
that referenced
this pull request
Feb 16, 2024
* Fix example commands in HelloWorld.html (#13) * Fix incorrect filename in mv commands * Update private keyword to be all caps as it is in the code * Update fpp model * Revert changes from `main` for history cleanliness --------- Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the mv commands that was listed as HelloWorld.hpp-template and HelloWorld.cpp-template. The actual files generated were HelloWorld.template.hpp and HelloWorld.template.cpp.
Changed the example where it uses the private keyword in HelloWorld.hpp to uppercase to make it match what is in the generated code.