DVR #68

shambler123 · 2021-05-22T00:56:47Z

this is a first version of a dvr recording with button and ambient audio. this will be updated soon

# Conflicts: # app/src/main/java/com/fpvout/digiview/MainActivity.java # app/src/main/java/com/fpvout/digiview/PerformancePreset.java # app/src/main/java/com/fpvout/digiview/VideoReaderExoplayer.java # app/src/main/java/usb/AndroidUSBOutputStream.java

# Conflicts: # app/build.gradle # app/src/main/java/com/fpvout/digiview/InputStreamDataSource.java # app/src/main/java/com/fpvout/digiview/MainActivity.java # app/src/main/java/com/fpvout/digiview/UsbMaskConnection.java # app/src/main/java/com/fpvout/digiview/VideoReaderExoplayer.java # app/src/main/java/usb/AndroidUSBInputStream.java

jlucidar

A few comments on how we could better integrate this :)
Great job !

app/src/main/AndroidManifest.xml

jlucidar · 2021-05-24T22:13:01Z

app/src/main/AndroidManifest.xml

    <uses-permission android:name="android.permission.WAKE_LOCK" />

    <application
        android:allowBackup="false"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:roundIcon="@mipmap/ic_launcher_round"
+        android:largeHeap="true"
+        android:requestLegacyExternalStorage="true"


Would be best to use scoped storage and shared directories :
https://developer.android.com/training/data-storage/shared/media

mhh i know bad habit to use the old implementation ;-)

for backwards compatibility I leave it as it is. we can change it later.

Better change it before a release/merge: WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 11 - even with 'android:requestLegacyExternalStorage'. Sdk level 11+ is required for updates starting November 2021. This could delay feature/bugfix rollouts until the dvr is reworked.

ok good to know! i will update that

app/src/main/java/com/fpvout/digiview/UsbMaskConnection.java

app/src/main/java/com/fpvout/digiview/InputStreamDataSource.java

app/src/main/java/com/fpvout/digiview/VideoReaderExoplayer.java

app/src/main/java/usb/AndroidUSBInputStream.java

app/src/main/java/com/fpvout/digiview/dvr/DVR.java

app/src/main/java/com/fpvout/digiview/helpers/StreamDumper.java

fmatt · 2021-05-26T18:48:01Z

app/src/main/AndroidManifest.xml

    <uses-permission android:name="android.permission.WAKE_LOCK" />

    <application
        android:allowBackup="false"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:roundIcon="@mipmap/ic_launcher_round"
+        android:largeHeap="true"
+        android:requestLegacyExternalStorage="true"


Better change it before a release/merge: WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 11 - even with 'android:requestLegacyExternalStorage'. Sdk level 11+ is required for updates starting November 2021. This could delay feature/bugfix rollouts until the dvr is reworked.

fmatt · 2021-05-26T19:11:54Z

app/src/main/java/com/fpvout/digiview/VideoReaderExoplayer.java

    private boolean zoomedIn;
    private final Context context;
    private PerformancePreset performancePreset = PerformancePreset.getPreset(PerformancePreset.PresetType.DEFAULT);
    static final String VideoZoomedIn = "VideoZoomedIn";
    private final SharedPreferences sharedPreferences;
+    private boolean streaming = false;
+
+    private VideoPlayingListener videoPlayingListener = null;


Listeners could be combined into one interface.

yeah, I kept them seperated so you can subscribe to an event in one place and to the other in another place (as you need to overide both methods when you implement it in a combined way )
Or maybe I just wasn't able to do it :p

fmatt · 2021-05-26T19:13:58Z

app/src/main/java/com/fpvout/digiview/VideoReaderExoplayer.java

-            videoReaderEventMessage.obj = eventCode;
-            videoReaderEventListener.sendMessage(videoReaderEventMessage);
-        }
+    public interface VideoPlayingListener {


This interfaces should go into their own files and might be combined.

fmatt · 2021-05-26T19:18:49Z

.idea/compiler.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>


Adding this file will mess with developers with a different environment, please consider removing it.

sry was a bit lazy and forget it. Normally android studio fixes itself ;-) We should add this file to the ignore list ;-)

fmatt · 2021-05-26T19:20:04Z

.idea/misc.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>


Adding this file will mess with developers with a different environment, please consider removing it.
It is likely to be overwritten by a gradle build.

sry was a bit lazy and forget it. Normally android studio fixes itself ;-) We should add this file to the ignore list ;-)

fmatt · 2021-05-26T19:27:27Z

app/src/main/java/com/fpvout/digiview/dvr/DVR.java

+        streamDumper = new StreamDumper(activity, defaultFolder);
+    }
+
+    public static DVR getInstance(Activity context, boolean recordAmbientAudio, Handler updateAfterRecord, UsbMaskConnection connection){


Keeping the context in a singleton might lead to a memory leak.

i will change it . The thing is i wanted to make sure only one instance is used in the whole app.

fmatt · 2021-05-26T19:29:19Z

app/src/main/java/com/fpvout/digiview/dvr/DVR.java

+                File file = files[i];
+                if (file.getAbsolutePath().endsWith(".h264")) {
+                    File ambientAudio = new File(file.getAbsolutePath().replace(".h264", ".aac"));
+                    if (ambientAudio.exists()) {


Consider muxing even if the ambient audio is not existing, to at least have a useable video file.

great idea !

Yes we can do that. No Problem 10 Mins of awesome sound ... you never know whats beeing recorded :D

# Conflicts: # app/build.gradle # app/src/main/java/com/fpvout/digiview/H264Extractor.java # app/src/main/java/com/fpvout/digiview/InputStreamBufferedDataSource.java # app/src/main/java/com/fpvout/digiview/InputStreamDataSource.java # app/src/main/java/com/fpvout/digiview/MainActivity.java # app/src/main/java/com/fpvout/digiview/PerformancePreset.java # app/src/main/java/com/fpvout/digiview/VideoReaderExoplayer.java # app/src/main/java/usb/AndroidUSBInputStream.java

jlucidar · 2021-12-01T19:27:58Z

Hey, I'm working on merging this with dev branch.
It looks great ! I just need to make a few minor fixes before pushing it :

better handling of the "gallery button" (I'd like to see if opening the gallery instead of last video look better)
bugfix : record file of more than 2Gb make the app crash. (due to the h264 muxer processing that happen in memory... I will check if I can do it in an other way or if we have to "cut" h264 file before the 2Gb limit)

I will add more to the list if I encounter other things in the way.

robertsmd · 2022-10-08T19:33:29Z

@jlucidar Any progress on merging this? I'm interested in using it. There are other apps similarly that have DVR, but this one has the best video latency.

Also, is there a way to not grant microphone privilege and still record? I did a quick pull and rebuild with commenting out the line recorder.setAudioSource(MediaRecorder.AudioSource.MIC);, but it still breaks.

I also am getting an issue where it crashes on stopping the recording. I'm unable to have adb and the goggles connected at the same time to help debug.

jlucidar · 2022-10-09T10:42:23Z

Hi @robertsmd, Haven't got the time to work on this project for a long time.
Most of the work done of the DVR was not done by myself so I might not be the best to answer your questions but I'll try to help :

The main issue I see before finishing the merge is that the video is only encoded when you stop recording. And it does it by loading the whole unencoded h264 file in memory. This is quite annoying on cheap devices with not a lot of memory, causing the app to crash and never start again (because we try to reencode the file if it was not done properly on the last ending). Maybe we can check how other people resolved this problem and find a similar way to achieve it.
According to the documentation, you should be able to just comment this line + recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC);
https://developer.android.com/reference/android/media/MediaRecorder#setAudioSource(int)
(I would add this to the option page so it would be configurable)
If you want adb, you can use it over your network by opening a remote session. (I usually do this so I can see what happened when playing with usb stuff) :
from your command line with usb connected to your device :

adb tcpip TCP_PORT
adb connect DEVICE_IP_ADDRESS:TCP_PORT

shambler123 · 2022-10-09T16:21:18Z

I had not had the time to complete the implementation as @jlucidar said it there are some issues that needs to be resolved first.

shambler123 changed the base branch from master to dev May 22, 2021 00:58

fichek marked this pull request as draft May 22, 2021 01:38

fichek changed the title ~~Feature/22~~ DVR May 22, 2021

jlucidar and others added 18 commits May 23, 2021 00:33

WIP refacto

518a325

bug fixes + Proper event handling for player (Observable Java pattern)

258e9a2

No more warnings + update dependencies

8aed123

add dvr feature

7e3a4f8

stuff

98457fe

rollback

e519abd

update dvr

806e25a

add missing files

556beb6

dvr version first

2f703fe

moved init

879ddb1

updated dvr branch

2fb45ad

rebased to new dev branch

5b29b5e

first version of dvr implementation. work in progress

42d04b9

updated style and minor changes

f2bc27e

rebased to dev

e31693c

merged refactor branch

45a38cc

shambler123 force-pushed the feature/22 branch from 39a47a6 to 45a38cc Compare May 24, 2021 13:35

markussta added 3 commits May 24, 2021 20:55

added feature for gallery button and fixed toolbar display bug

4efb67c

removed isRecording check from MainActivity

e0b6c7f

added thumb update to different locations

60cb09b

jlucidar reviewed May 24, 2021

View reviewed changes

jlucidar added the enhancement New feature or request label May 24, 2021

jlucidar assigned shambler123 May 24, 2021

jlucidar added this to the v1.0.0 milestone May 24, 2021

minor updates

c99dd7c

markussta added 4 commits May 25, 2021 11:51

fixed some perfomance issues and recording lags on the dvr

b04bc43

changed to a different access to InputStream

f44645b

changed from handler to Listener

6f17c81

added dvr repair function

6710312

shambler123 marked this pull request as ready for review May 26, 2021 03:48

shambler123 linked an issue May 26, 2021 that may be closed by this pull request

Add IN-APP DVR #22

Open

fichek requested a review from fmatt May 26, 2021 11:39

markussta added 3 commits May 26, 2021 16:02

fixed crash on dvr repair

46280c6

removed toast causes crashes ...

ff5dc68

on overlay visible show toolbar as well

4f6d55c

fmatt suggested changes May 26, 2021

View reviewed changes

MathisEngels mentioned this pull request Jun 4, 2021

Feature request: Stream recording (because SD card in Goggles are not working) #84

Closed

markussta and others added 3 commits June 7, 2021 16:31

Merge branch 'dev' into feature/22

b481180

reorganize mainActivity to facilitate merge

c5ef237

minor tweaking of the DVR toolbar look / fix typo

e4af1f5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DVR #68

DVR #68

shambler123 commented May 22, 2021

jlucidar left a comment

jlucidar May 24, 2021

shambler123 May 25, 2021 •

edited

Loading

shambler123 May 26, 2021

fmatt May 26, 2021

shambler123 May 28, 2021

fmatt May 26, 2021

fmatt May 26, 2021

jlucidar May 27, 2021

fmatt May 26, 2021

fmatt May 26, 2021

shambler123 May 27, 2021

fmatt May 26, 2021

shambler123 May 27, 2021

fmatt May 26, 2021

shambler123 May 27, 2021

fmatt May 26, 2021

jlucidar May 27, 2021

shambler123 May 27, 2021

jlucidar commented Dec 1, 2021

robertsmd commented Oct 8, 2022 •

edited

Loading

jlucidar commented Oct 9, 2022

shambler123 commented Oct 9, 2022

DVR #68

Are you sure you want to change the base?

DVR #68

Conversation

shambler123 commented May 22, 2021

jlucidar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shambler123 May 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlucidar commented Dec 1, 2021

robertsmd commented Oct 8, 2022 • edited Loading

jlucidar commented Oct 9, 2022

shambler123 commented Oct 9, 2022

shambler123 May 25, 2021 •

edited

Loading

robertsmd commented Oct 8, 2022 •

edited

Loading