Feature/rtmp stream screen #79
Conversation
|
Actually, I think it can be a better solution than direct stream from the socket, as you mentionned, we don't want the stream to cut on lipo changes, or goggle disconnections, even more if we add mic audio to the stream ! Maybe adding an option to display front cam / back cam in the bottom left corner, would be great (then you have like a real stream app feature !) I will review the code tomorrow ^^ |
| }); | ||
| } | ||
|
|
||
| private void hideFullOverlay() { |
There was a problem hiding this comment.
this is going to conflict with some of my work on refacto branch. We should discuss how to handle overlay in a better way, having all the logic in the main activity is kind of a pain...
| @@ -376,7 +397,7 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) { | |||
| SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(getApplicationContext()); | |||
| boolean dataCollectionAccepted = preferences.getBoolean("dataCollectionAccepted", false); | |||
|
|
|||
| if (requestCode == 1) { // Data Collection agreement Activity | |||
| if (requestCode == DATA_COLLECTION_AGREEMENT) { // Data Collection agreement Activity | |||
There was a problem hiding this comment.
this will also be removed by #73 to follow API30 new guidelines.
omouren
force-pushed
the
feature/rtmp-stream-screen
branch
from
9b1af78 to
3f7d9a5
Compare
I had the same idea for the camera, I think it would be a nice to have! |
|
Let's make it a separate feature though, it could be useful on DVR too ^^
Le mar. 1 juin 2021 à 19:02, Olivier Mouren ***@***.***> a
écrit :
… Actually, I think it can be a better solution than direct stream from the
socket, as you mentionned, we don't want the stream to cut on lipo changes,
or goggle disconnections, even more if we add mic audio to the stream !
Maybe adding an option to display front cam / back cam in the bottom left
corner, would be great (then you have like a real stream app feature !)
I will review the code tomorrow ^^
I had the same idea for the camera, I think it would be a nice to have!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#79 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYWCUQTWTPWPIVURFELETLTQUHD3ANCNFSM452Y4IFQ>
.
|
|
|
|
Cool ! Would be neat to add the stat as requested by #44 . will work for now, but I think it will look better :) |
omouren
force-pushed
the
feature/rtmp-stream-screen
branch
from
ea0656e to
c87fce6
Compare
WIP
An other approach for the RTMP stream by recording the entire screen.
Previous PR : #75
Advantage of a full screen recording : simpler in code, handled natively by Android (MediaProjection), can continue to stream without the video (during a lipo switch for exemple)
Disadvantage : it records all the screen in background, even when you switch to an other app or receive a notification, it's not a direct video from USB streaming.
Made some refactor with the overlay/buttons/watermark display/hide
+ Some wording update for french translations (#80)
If someone can make an icon for a "start live" and "stop live" button maybe? You're welcome!
Todo :
We should find a way to keep a preview of the video streamNot a problem here