considers the use of ".css?[hash]" or ".js?[hash]" #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqborges
force-pushed
the
master
branch
2 times, most recently
from
3e17fce
to
3e3767d
Compare
|
Hello! Thanks for your PR, but it got lost between my vacations and all this corona virus thing. I just found it now reviewing other PRs. Could you please rebase to a single commit, add a test and resubmit? |
|
This pull request actually fixes the problem I am currently encountering. |
|
It didn't got merged because 'lastIndexOf(js)' is not the same as 'endswith(js?[hash])'. You can pick from there and improve. It would be wonderful! The best solution probably would be regexps for identifying ignores (js, mjs, js?[hash]) and matches (css, scss) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to add a hash after the CSS extension, and this change considers that file format.