Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol error infinite loop #14

Closed
kavol opened this issue Jan 7, 2016 · 2 comments
Closed

protocol error infinite loop #14

kavol opened this issue Jan 7, 2016 · 2 comments
Assignees
Labels

Comments

@kavol
Copy link

kavol commented Jan 7, 2016

Trying to use AndrOBD with my car (see issue #10), version 1.3.9 crashes.
It displays an error, see the screenshot, many times and then it closes, presumably exhausting resources.

screenshot_2016-01-06-19-04-47

@kavol
Copy link
Author

kavol commented Jan 7, 2016

logs here: http://uloz.to/x78n1mJN/androbd-16-01-06-zip
(this tracker still doesn't accept zip despite it says it does ...)

@fr3ts0n fr3ts0n closed this as completed in 31b68e8 Jan 8, 2016
@fr3ts0n fr3ts0n added the bug label Jan 8, 2016
@fr3ts0n fr3ts0n self-assigned this Jan 8, 2016
@fr3ts0n
Copy link
Owner

fr3ts0n commented Jan 8, 2016

Thanks for the report.

Yep. this was a loop condition, since the service request was not aborted with the NRC.
The loop was triggered with the ELM prompt which wasn't part of my ELM simulation for testing ...

fixed with V1.3.11

fr3ts0n added a commit that referenced this issue Jan 30, 2016
fixed #14 - initialize ELM adapter on NRC (configurable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants