You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tasks/collection.py module is quite messy, and its tests are scattered in different modules with no obvious logic. This is confusing, while developing e.g. PR #1188.
I will close this with #1188, which includes a refactor that does not change functionality (on top of the actual changes related to #736). The new structure is as follows
$ tree fractal_server/tasks/fractal_server/tasks/├── background_operations.py├── endpoint_operations.py├── __init__.py├── _TaskCollectPip.py└── utils.py0 directories, 5 files
$ tree tests/07_task_collection/tests/07_task_collection/├── test_background_operations.py├── test_endpoint_operations.py└── test_unit_tasks.py0 directories, 3 files
which at least places definitions in some appropriately scoped module.
Note that a review of the task-collection flow is still due, although not urgent. As an example, to start with, the fact that we often call the check method is a hint that some abstractions are not correct.
The
tasks/collection.py
module is quite messy, and its tests are scattered in different modules with no obvious logic. This is confusing, while developing e.g. PR #1188.Within
tasks
, we should separate e.g.:A similar organization can be used for unit/API tests.
This will help us to clearly determine which functions rely on which assumptions (e.g. which functions use normalized package names).
The text was updated successfully, but these errors were encountered: