-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split CI #2210
Open
ychiucco
wants to merge
18
commits into
dev-2.11
Choose a base branch
from
2203-split-v2-ci-into-two-gha-jobs
base: dev-2.11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Split CI #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
The API tests are actually using the SSH containers, thus we need a better split. For the record, here is part of the output of $ poetry run pytest -vv tests/v2/03_api/ --durations 0
[...]
======= slowest durations ====================
25.33s call tests/v2/03_api/test_api_task_collection.py::test_task_collection_from_pypi[None]
24.44s call tests/v2/03_api/test_api_task_collection.py::test_task_collection_from_pypi[1.3.2]
21.56s call tests/v2/03_api/test_api_task_collection_ssh.py::test_task_collection_ssh_from_pypi
16.44s setup tests/v2/03_api/test_api_task_collection_ssh.py::test_task_collection_ssh_from_pypi
12.38s call tests/v2/03_api/test_api_task_lifecycle.py::test_lifecycle[slurm_ssh]
11.15s call tests/v2/03_api/test_api_task_lifecycle.py::test_lifecycle[local]
11.09s call tests/v2/03_api/test_api_task_collection_failures.py::test_invalid_manifest
8.08s call tests/v2/03_api/test_api_task_collection.py::test_task_collection_from_wheel_non_canonical
6.46s call tests/v2/03_api/test_api_task_collection_ssh.py::test_task_collection_ssh_from_wheel
6.39s call tests/v2/03_api/test_api_task_collection_failures.py::test_failure_cleanup
6.14s call tests/v2/03_api/test_api_task_collection.py::test_task_collection_from_wheel_file
5.34s call tests/v2/03_api/test_api_task_collection_failures.py::test_missing_task_executable
4.53s setup tests/v2/03_api/test_api_workflow.py::test_delete_workflow
3.00s setup tests/v2/03_api/test_api_task_collection_custom.py::test_task_collection_custom
1.65s call tests/v2/03_api/test_api_job.py::test_project_apply_workflow_subset
1.51s teardown tests/v2/03_api/test_unit_timezone.py::test_timezone_api
0.99s call tests/v2/03_api/admin/test_admin_others.py::test_task_query
[...]
================= 1 failed, 143 passed, 919 warnings in 222.71s (0:03:42) ==================
Some first comments:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2203
Checklist before merging
CHANGELOG.md
main
into the current branch.