Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zenodo dataset, setting channel.active to True #823

Open
tcompa opened this issue Aug 28, 2024 · 3 comments
Open

Update zenodo dataset, setting channel.active to True #823

tcompa opened this issue Aug 28, 2024 · 3 comments

Comments

@tcompa
Copy link
Collaborator

tcompa commented Aug 28, 2024

Ref fractal-analytics-platform/fractal-vizarr-viewer#20.

  1. Review the current situation: how are we setting the active attribute of a channel?
  2. Decide how we should proceed in the converters. Do we always mark all channels as "active"? Do we only do it for at most N channels? ...
@tcompa
Copy link
Collaborator Author

tcompa commented Aug 28, 2024

Review the current situation: how are we setting the active attribute of a channel?

How comes we have some zarrs lying around without active=true for channels? For sure the tiny one on zenodo (https://zenodo.org/records/13305156) doesn't have active metadata.

Decide how we should proceed in the converters. Do we always mark all channels as "active"? Do we only do it for at most N channels? ...

I guess that we can continue as we do now. If the user does not specify anything in the converter arguments, all channels are marked as active.

@tcompa tcompa changed the title Review whether channel.active is set to True Update zenodo dataset, setting channel.active to True Aug 28, 2024
@tcompa
Copy link
Collaborator Author

tcompa commented Aug 29, 2024

After re-running examples 01 and 02 from fractal-demos, I confirm that their .zattrs does not include the active field.
TBD

@jluethi jluethi added the ngio label Sep 9, 2024
@jluethi
Copy link
Collaborator

jluethi commented Sep 9, 2024

@lorenzocerrone Something to keep in mind in the ngio context. If we can, let's make sure channels have active=True unless there's an active decision against it. That avoids many confusions about channels not being shown e.g. in vizarr ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants