Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on pydantic._internal #835

Open
tcompa opened this issue Sep 9, 2024 · 1 comment
Open

Reduce dependency on pydantic._internal #835

tcompa opened this issue Sep 9, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file JSON Schemas

Comments

@tcompa
Copy link
Collaborator

tcompa commented Sep 9, 2024

See #834.

We currently have these imports

from pydantic._internal import _generate_schema
from pydantic._internal import _typing_extra
from pydantic._internal._config import ConfigWrapper

I think we can at least get rid of the specific _typing_extra.add_module_globals function that changed when passing from 2.8.2 to 2.9.0 (pydantic/pydantic@8dc0ce3), and maybe we can also reduce dependency on ConfigWrapper. Whether we can also avoid depending on _generate_schema.GenerateSchema is TBD.

@tcompa tcompa added JSON Schemas dependencies Pull requests that update a dependency file labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file JSON Schemas
Projects
Development

No branches or pull requests

1 participant