Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate JSchema component within Workflow page #188

Merged
merged 11 commits into from
Jun 21, 2023
Merged

Integrate JSchema component within Workflow page #188

merged 11 commits into from
Jun 21, 2023

Conversation

rkpasia
Copy link
Contributor

@rkpasia rkpasia commented Jun 20, 2023

This integration enables the usage of JSchema component as mean to handle arguments edits with schema restrictions.

@rkpasia
Integration of JSchema with workflows page
3c1a844 
- If a selected task with args_schema property defined is provided, load the JSchema component within the experimental tab.
- Display a missing schema alert in tab if no args_schema is available
- Disable preventing the rendering of JSchema if provided data is not compliant with the schema
@rkpasia
Use selectedWorkflowTask.args as property to bind to JSchema's schema…
5e61b47 
…Data prop.

Update schemaData initialization.
@rkpasia
Handle saving and validating in wrapper component in order to customi…
ec982d5 
…ze the behaviour of JSchema.

- Now the client saves the arguments provided through JSchema
- The client validates against the schema that the args are valid
- If there are validations errors upon save, they are displayed for the user to have a feedback.
@rkpasia rkpasia requested a review from tcompa June 20, 2023 06:12
@rkpasia
Copy link
Contributor Author

rkpasia commented Jun 21, 2023

This solves:

It's ready to be merged.

@rkpasia rkpasia merged commit 45e7f19 into main Jun 21, 2023
@rkpasia rkpasia deleted the jschema_integration_with_workflow_page branch June 21, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcompa tcompa Awaiting requested review from tcompa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rkpasia