replace table setter with set_table method

fractal-analytics-platform · Oct 14, 2024 · a3cdf89 · a3cdf89
1 parent f416062
commit a3cdf89
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 3 deletions.
diff --git a/src/ngio/tables/v1/_generic_table.py b/src/ngio/tables/v1/_generic_table.py
@@ -92,6 +92,12 @@ def table(self) -> pd.DataFrame:
 
     @table.setter
     def table(self, table: pd.DataFrame) -> None:
+        raise NotImplementedError(
+            "Setting the table directly is not supported. "
+            "Please use the 'set_table' method."
+        )
+
+    def set_table(self, table: pd.DataFrame) -> None:
         table = validate_table(
             table_df=table,
             index_key=self.index_key,

diff --git a/src/ngio/tables/v1/feature_tables.py b/src/ngio/tables/v1/feature_tables.py
@@ -118,7 +118,13 @@ def table(self) -> pd.DataFrame:
     @table.setter
     def table(self, table: pd.DataFrame):
         """Set the feature table."""
-        self._table_handler.table = table
+        raise NotImplementedError(
+            "Setting the table is not implemented. Please use the 'set_table' method."
+        )
+
+    def set_table(self, table: pd.DataFrame):
+        """Set the feature table."""
+        self._table_handler.set_table(table)
 
     def label_image_name(self, get_full_path: bool = False) -> str:
         """Return the name of the label image.

diff --git a/src/ngio/tables/v1/masking_roi_tables.py b/src/ngio/tables/v1/masking_roi_tables.py
@@ -134,7 +134,14 @@ def table(self) -> pd.DataFrame:
 
     @table.setter
     def table(self, table: pd.DataFrame):
-        self._table_handler.table = table
+        """Set the feature table."""
+        raise NotImplementedError(
+            "Setting the table is not implemented. Please use the 'set_table' method."
+        )
+
+    def set_table(self, table: pd.DataFrame):
+        """Set the feature table."""
+        self._table_handler.set_table(table)
 
     @property
     def list_labels(self) -> list[str]:

diff --git a/src/ngio/tables/v1/roi_tables.py b/src/ngio/tables/v1/roi_tables.py
@@ -153,7 +153,14 @@ def table(self) -> pd.DataFrame:
 
     @table.setter
     def table(self, table: pd.DataFrame):
-        self._table_handler.table = table
+        """Set the feature table."""
+        raise NotImplementedError(
+            "Setting the table is not implemented. Please use the 'set_table' method."
+        )
+
+    def set_table(self, table: pd.DataFrame):
+        """Set the feature table."""
+        self._table_handler.set_table(table)
 
     @property
     def field_indexes(self) -> list[str]: