WIP: Begin experimenting with memoizing the ActiveSet operation methods #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I should profile this gem before and after applying this change to see how it affects things. |
fractaledmind
changed the title
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| def filter(instructions_hash) | ||
| filterer = Filtering::Operation.new(@view, instructions_hash) | ||
| reinitialize(filterer.execute, :filter, filterer.operation_instructions) | ||
| @filtered_set ||= Hash.new do |h, (view, instructions_hash)| |
There was a problem hiding this comment.
Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - instructions_hash.
| def filter(instructions_hash) | ||
| filterer = Filtering::Operation.new(@view, instructions_hash) | ||
| reinitialize(filterer.execute, :filter, filterer.operation_instructions) | ||
| @filtered_set ||= Hash.new do |h, (view, instructions_hash)| |
There was a problem hiding this comment.
UncommunicativeVariableName: ActiveSet#filter has the variable name 'h'. More info.
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 99.76% 99.76% +<.01%
==========================================
Files 17 17
Lines 421 423 +2
==========================================
+ Hits 420 422 +2
Misses 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.