Automatically connect to replicated peers #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: By default we only connect to people that we're directly following, which often don't have public IP addresses. Solution: Automatically connect to all available peers within our replication hops (default 2) to make peering more reliable.
This was
linked to
issues
Mar 25, 2020
|
How does this behave for you? For me, ssb.conn.stagedPeers() seems to give the same three peers over and over again (none of which happen to be within hop range for me). |
sbillig
reviewed
Mar 27, 2020
| lodash.get(ssbConfig, "friends.hops", 0) | ||
| ); | ||
|
|
||
| const add = address => { |
There was a problem hiding this comment.
It looks to me like ssb-conn's (ssb-conn-hub's) connect function already handles this (connect() returns false if there's already a connection open or in progress), so inProgress and add probably aren't necessary.
There was a problem hiding this comment.
Nice catch! I noticed that the same person was showing up multiple times in my peer list, but maybe one was just { state: 'connecting' }.
Here's what I'm seeing: I think the right way to do this would be to make the hops configurable in SSB-CONN, but I'm not sure if that's an option (see ssbc/ssb-conn#16). |
|
I read ssb-conn's readme; staging contains peers with autoconnect=false, and these three peers were the only ones with autoconnect=false in my conn.json, for whatever reason. After moving conn.json (and gossip.json for good measure), everything in conn.json is autoconnect=false, so this makes more sense now. Bluetooth peers are also in staging, so a possible side effect is that we'd hypothetically aggressively connect to bt peers, but that seems fine (?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: By default we only connect to people that we're directly
following, which often don't have public IP addresses.
Solution: Automatically connect to all available peers within our
replication hops (default 2) to make peering more reliable.