-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/observers #50
Conversation
- Use `MetricValue` instead of `isize`. - Cancel handle in example. - Configurable thread name.
- If multiple callbacks are registered under the same conflicting key, only the last one will survive. - It would be especially bad if the callback was re-registered periodically. The memory would increase and even all historical callbacks would be executed during each iteration.
|
I'm not sure about the |
9062674
to
8c764d0
Compare
4990f69
to
7593eea
Compare
…to feature/observers
188141b
to
0b376e4
Compare
18285f6
to
f59d403
Compare
f59d403
to
23dc724
Compare
f16e9fb
to
7028ae9
Compare
@mixalturek last call for API changes, this is ready to merge! I'm satisfied with the new API and I believe I went back to something close to your original proposal:
What do you think? I'm sorry for taking so long and clobbering your original PR... Some lower-level changes were required for this to work, mainly the flush notifications and a new shared-thread scheduler (so we don't create a new thread for every observed gauge). Your original commits are still in the commit log for posterity, if it's something you care about :) |
Hi, I'm sorry, I had and have too many other tasks from many directions and didn't have time for this at all. I also received no email notification about your work until yesterday, so I fully missed everything. The API described in the comment above looks great! |
No description provided.