Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print statement left in the plugin's code? [1.2.0] #242

Closed
FredZinelli opened this issue Sep 16, 2024 · 4 comments
Closed

Print statement left in the plugin's code? [1.2.0] #242

FredZinelli opened this issue Sep 16, 2024 · 4 comments
Labels
bug Something isn't working fixed A fix has been submitted

Comments

@FredZinelli
Copy link

Hello,

Glad to see the 1.2 out !
Just so that you know: maybe it's intended (though, it's not using the logger), there is a print statement left in the plugin's _load_module method, line 510

Cheers

Copy link

Welcome to this project and thank you!' first issue

@fralau fralau added bug Something isn't working planned This is planned for correction labels Sep 17, 2024
@fralau
Copy link
Owner

fralau commented Sep 18, 2024

Thanks for the heads-up: having that kind of quality check from the user community, in addition to other tools, helps a lot!

fralau pushed a commit that referenced this issue Sep 18, 2024
@timvink
Copy link
Contributor

timvink commented Sep 24, 2024

Try enabling some ruff rules on the project via GitHub actions or precommit hooks. It can auto detect those kind of issues. https://github.com/astral-sh/ruff

@fralau
Copy link
Owner

fralau commented Sep 26, 2024

@timvink Thanks for this suggestion (ruff is a Linter). This is part of the ongoing reflection on code quality assurance for this project.

@fralau fralau added fixed A fix has been submitted solved The issue has been satisfactorily solved and removed planned This is planned for correction solved The issue has been satisfactorily solved labels Sep 26, 2024
@fralau fralau closed this as completed Sep 26, 2024
@fralau fralau changed the title print statement left in the plugin's code? [1.2.0] Print statement left in the plugin's code? [1.2.0] Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed A fix has been submitted
Projects
None yet
Development

No branches or pull requests

3 participants