Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/page layout #221

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Feat/page layout #221

merged 5 commits into from
Oct 4, 2023

Conversation

bddjong
Copy link
Contributor

@bddjong bddjong commented Sep 21, 2023 •
edited
Loading

Adds most of the essential page layout styling and components. Some of these should be ported to the design system, but getting them functional in this website is more important.

  • Added grid layout
  • Added cards
  • Corrected page sizes and content margins
  • Corrected footer size (full width)

Note

The image in cards can't be edited from the CMS yet. I'll be opening a separate PR for image uploads

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pdc-dashboard ❌ Failed (Inspect) Sep 25, 2023 8:05am
strapi-pdc-frontend ❌ Failed (Inspect) Sep 25, 2023 8:05am

@bddjong bddjong force-pushed the feat/page-layout branch 3 times, most recently from 9241185 to b4a3ec0 Compare October 2, 2023 05:22
@bddjong bddjong marked this pull request as ready for review October 2, 2023 05:23
@bddjong bddjong requested a review from AliKdhim87 October 2, 2023 05:23
@bddjong bddjong self-assigned this Oct 2, 2023
@bddjong bddjong force-pushed the feat/page-layout branch 4 times, most recently from 69b95f0 to 8ef115f Compare October 2, 2023 06:34
@bddjong bddjong force-pushed the feat/page-layout branch 2 times, most recently from e4f7201 to 8fb34d8 Compare October 4, 2023 08:09
@bddjong bddjong merged commit ca8f055 into main Oct 4, 2023
2 checks passed
@bddjong bddjong deleted the feat/page-layout branch October 4, 2023 08:44
@AliKdhim87
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@AliKdhim87
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on @frameless/provider-upload-vercel@1.1.0

Your semantic-release bot 📦🚀

@AliKdhim87
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@AliKdhim87
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@AliKdhim87
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on @frameless/ui@1.1.0

Your semantic-release bot 📦🚀

@AliKdhim87
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliKdhim87 AliKdhim87 AliKdhim87 left review comments

Assignees

@bddjong bddjong

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bddjong @AliKdhim87