Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pdc dashboard field description #238

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Improve pdc dashboard field description #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2765e5a
chore(pdc-dashboard): improve the field description
AliKdhim87 Oct 10, 2023
0e7d303
fix(pdc-dashboard): set the text & href attributes of button-link to …
AliKdhim87 Oct 10, 2023
e72a972
fix(pdc-dashboard): set the text & href attributes of logo-button to …
AliKdhim87 Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ync/core-store.plugin_content_manager_configuration_components##components.accordion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"title": {
"edit": {
"label": "Titel",
"description": "",
"description": "Titel of vraag van de FAQ",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -37,7 +37,7 @@
"body": {
"edit": {
"label": "Inhoud",
"description": "",
"description": "Inhoud of antwoord voor de FAQ",
"placeholder": "",
"visible": true,
"editable": true
Expand Down
2 changes: 1 addition & 1 deletion ...core-store.plugin_content_manager_configuration_components##components.block-content.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"content": {
"edit": {
"label": "content",
"label": "Page inhoud",
"description": "",
"placeholder": "",
"visible": true,
Expand Down
20 changes: 10 additions & 10 deletions ...c/core-store.plugin_content_manager_configuration_components##components.button-link.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
},
"text": {
"edit": {
"label": "text",
"description": "",
"label": "Text",
"description": "Specificeert de weergegeven tekst",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -36,8 +36,8 @@
},
"href": {
"edit": {
"label": "href",
"description": "",
"label": "Href",
"description": "Geeft de koppelingbestemming aan wanneer er op de knop wordt geklikt",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -50,8 +50,8 @@
},
"icon": {
"edit": {
"label": "icon",
"description": "",
"label": "Icon",
"description": "Hiermee kunt u een pijl icoon naast de knop opnemen.",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -64,8 +64,8 @@
},
"label": {
"edit": {
"label": "label",
"description": "",
"label": "Label",
"description": "Voegt een titel of beschrijving boven de knop toe.",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -78,8 +78,8 @@
},
"button_link_appearance": {
"edit": {
"label": "button_link_appearance",
"description": "",
"label": "Appearance",
"description": "Beheert de visuele stijl",
"placeholder": "",
"visible": true,
"editable": true
Expand Down
4 changes: 2 additions & 2 deletions ...nfig/sync/core-store.plugin_content_manager_configuration_components##components.faq.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
},
"faq": {
"edit": {
"label": "faq",
"description": "",
"label": "FAQ",
"description": "Verbindt dit element met een verzameling veelgestelde vragen (FAQ's). U kunt dit element associëren met een specifieke FAQ-collectie, zodat gebruikers toegang hebben tot relevante FAQ's die verband houden met deze inhoud.",
"placeholder": "",
"visible": true,
"editable": true,
Expand Down
2 changes: 1 addition & 1 deletion ...ig/sync/core-store.plugin_content_manager_configuration_components##components.image.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"imageData": {
"edit": {
"label": "imageData",
"label": "Afbeelding",
"description": "",
"placeholder": "",
"visible": true,
Expand Down
20 changes: 10 additions & 10 deletions ...c/core-store.plugin_content_manager_configuration_components##components.logo-button.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
},
"label": {
"edit": {
"label": "label",
"description": "",
"label": "Label",
"description": "Voegt een titel of beschrijving boven de knop toe.",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -36,8 +36,8 @@
},
"href": {
"edit": {
"label": "href",
"description": "",
"label": "Href",
"description": "Geeft de koppelingbestemming aan wanneer er op de knop wordt geklikt",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -50,8 +50,8 @@
},
"text": {
"edit": {
"label": "text",
"description": "",
"label": "Text",
"description": "Specificeert de weergegeven tekst",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -64,8 +64,8 @@
},
"logo": {
"edit": {
"label": "logo",
"description": "",
"label": "Logo",
"description": "Hiermee kunt u een logo naast de knop opnemen.",
"placeholder": "",
"visible": true,
"editable": true
Expand All @@ -78,8 +78,8 @@
},
"logo_button_appearance": {
"edit": {
"label": "logo_button_appearance",
"description": "",
"label": "Appearance",
"description": "Beheert de visuele stijl",
"placeholder": "",
"visible": true,
"editable": true
Expand Down
4 changes: 2 additions & 2 deletions ...lugin_content_manager_configuration_components##components.multi-columns-button-item.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
},
"title": {
"edit": {
"label": "title",
"description": "",
"label": "Title",
"description": "De titel weergegeven aan de bovenkant van elke kolom, indien opgegeven. Deze titel helpt bij het organiseren en labelen van de inhoud binnen de kolom.",
"placeholder": "",
"visible": true,
"editable": true
Expand Down
2 changes: 1 addition & 1 deletion ...ore.plugin_content_manager_configuration_components##components.multi-columns-button.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"column": {
"edit": {
"label": "column",
"label": "Column",
"description": "",
"placeholder": "",
"visible": true,
Expand Down
2 changes: 1 addition & 1 deletion ...ync/core-store.plugin_content_manager_configuration_components##sections.faq-section.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"accordion": {
"edit": {
"label": "accordion",
"label": "Accordion",
"description": "",
"placeholder": "",
"visible": true,
Expand Down
12 changes: 6 additions & 6 deletions ...fig/sync/core-store.plugin_content_manager_configuration_content_types##api##faq.faq.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
},
"title": {
"edit": {
"label": "title",
"description": "",
"label": "Title",
"description": "Hoofdtitel voor de FAQ-collectie",
"placeholder": "",
"visible": true,
"editable": true
Expand Down Expand Up @@ -81,14 +81,14 @@
"edit": [
[
{
"name": "faq",
"size": 12
"name": "title",
"size": 6
}
],
[
{
"name": "title",
"size": 6
"name": "faq",
"size": 12
}
]
],
Expand Down
12 changes: 7 additions & 5 deletions ...sync/core-store.plugin_content_manager_configuration_content_types##api##price.price.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"title": {
"edit": {
"label": "Titel ",
"description": "",
"description": "Hoofdtitel voor de Prijs-collectie",
"placeholder": "",
"visible": true,
"editable": true
Expand Down Expand Up @@ -94,17 +94,19 @@
},
"layouts": {
"edit": [
[
{
"name": "title",
"size": 6
}
],
[
{
"name": "price",
"size": 12
}
],
[
{
"name": "title",
"size": 6
},
{
"name": "products",
"size": 6
Expand Down
6 changes: 4 additions & 2 deletions apps/pdc-dashboard/src/components/components/button-link.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@
"options": {},
"attributes": {
"text": {
"type": "string"
"type": "string",
"required": true
},
"href": {
"type": "string"
"type": "string",
"required": true
},
"icon": {
"type": "boolean"
Expand Down
6 changes: 4 additions & 2 deletions apps/pdc-dashboard/src/components/components/logo-button.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@
"type": "string"
},
"href": {
"type": "string"
"type": "string",
"required": true
},
"text": {
"type": "string"
"type": "string",
"required": true
},
"logo": {
"type": "enumeration",
Expand Down
Loading