Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial version of Localization Import & Export #130

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tom-james-watson
Copy link
Contributor

@tom-james-watson tom-james-watson commented Dec 3, 2024

Description

Adds an initial version of a "Localization Import & Export" plugin, which uses the new unstable localization APIs that are under development.

Depends on https://github.com/framer/FramerStudio/pull/19930.

Closes https://github.com/framer/company/issues/31112.

Testing

  • Download and install https://poedit.net/
  • Use an alpha channel project
  • Create a project and add some pieces of rich text to the canvas
  • Set default locale and add two locales
  • Translate some items and leave others untranslated
  • Go to localization view and press Plugins
  • Open plugin from URL: https://plugins-l2p4yzcb8-framer-app.vercel.app/localization-import-export
  • Confirm that you can select each locale and export an xliff file
  • Open the file with Poedit, make some changes to translations and save the file
  • Open the plugin again and import the updated file
  • The updated translations should be reflected in Framers localizations

@tom-james-watson tom-james-watson force-pushed the localization-import-export branch from 433a0df to 50053d1 Compare December 3, 2024 13:51
@tom-james-watson tom-james-watson marked this pull request as ready for review December 3, 2024 13:55
@tom-james-watson tom-james-watson changed the title Add iniitial version of Localization Import & Export Add initial version of Localization Import & Export Dec 3, 2024
plugins/localization-import-export/.gitignore Outdated Show resolved Hide resolved
plugins/localization-import-export/src/App.tsx Outdated Show resolved Hide resolved
plugins/localization-import-export/src/App.tsx Outdated Show resolved Hide resolved
plugins/localization-import-export/src/xliff.ts Outdated Show resolved Hide resolved
plugins/localization-import-export/src/xliff.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@alecmev alecmev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌 Leaving QA to Hunter though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants