Skip to content

Commit

Permalink
refactor: 🎨 cleaned a few things up
Browse files Browse the repository at this point in the history
  • Loading branch information
arctic-hen7 committed Sep 18, 2021
1 parent 7335418 commit 0ab791f
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions examples/cli/.perseus/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ pub fn run() -> Result<(), JsValue> {
templates => &get_templates_map(),
locales => &get_locales()
}
// TODO integrate templates fully
// BUG router sees empty template and moves on, fixed by above

sycamore::render_to(
|| {
Expand All @@ -72,7 +70,6 @@ pub fn run() -> Result<(), JsValue> {
// If the user is using i18n, then they'll want to detect the locale on any paths missing a locale
// Those all go to the same system that redirects to the appropriate locale
// Note that `container` doesn't exist for this scenario
// TODO redirect doesn't work until reload
RouteVerdict::LocaleDetection(path) => detect_locale(path.clone(), get_locales()),
// We handle the 404 for the user for convenience
// To get a translator here, we'd have to go async and dangerously check the URL
Expand Down
1 change: 0 additions & 1 deletion examples/showcase/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ define_app! {
crate::templates::index::get_template::<G>(),
crate::templates::about::get_template::<G>(),
crate::templates::new_post::get_template::<G>(),
// BUG: Sycamore doesn't support dynamic paths before dynamic segments (https://github.com/sycamore-rs/sycamore/issues/228)
crate::templates::post::get_template::<G>(),
crate::templates::ip::get_template::<G>(),
crate::templates::time_root::get_template::<G>(),
Expand Down
1 change: 0 additions & 1 deletion packages/perseus/src/shell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use crate::ErrorPages;
use std::cell::RefCell;
use std::collections::HashMap;
use std::rc::Rc;
use sycamore::prelude::Template as SycamoreTemplate;
use sycamore::prelude::*;
use wasm_bindgen::prelude::*;
use wasm_bindgen::JsCast;
Expand Down

0 comments on commit 0ab791f

Please sign in to comment.