-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples from 0.3.x included in docs for 0.2.x #60
Comments
Ah. v0.3.0 will go stable tomorrow, so I'd advise upgrading for now, but that is a very clear problem in the docs that needs solving! Thanks for the report! |
This will require getting previous version of files with |
Great! I didn't look up how the docs are generated, so I don't have suggestions how to fix it. |
…th problems Also added warning to readme about invalid examples for older versions as per #60.
For some reason this isn't building correctly. Reopening until I've figured that out. |
Okay, this was easily fixed by making the Checkout action copy in the whole Git history with |
Also, I feel I should add to this that saying v0.3.0 would be stabilized today was incorrect (sorry!), that was before the plugins system was scheduled for that release, so it'll be a little while before it goes stable. See #58 for details. That said, v0.3.0 is perfectly usable in beta form. |
OK, no problem. At the moment, I'm just experimenting, so switching from v0.2.x to v0.3.0 shouldn't be a problem. Regarding plugins, if I plan to use |
Right now, that's ambiguous, because that'd be setup/teardown code (rather than modifying any existing Perseus behavior), but it would either be type 1 or type 2. Likely type 1. |
The second app from (stable) docs does not compile. The reason for it seems like the wrong code snippets are included (those from 0.3.x, not 0.2.x). For example, in the 5th snippet one has
RenderFnResultWithCause
while in the text it is not mentioned at all (I presumeStringResultWithCause
is an old name for it).To Reproduce
Steps to reproduce the behavior:
perseus serve
throws a bunch of errorsExpected behavior
I expect that the example compiles as described :-)
Actual result
(...)
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: