-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router not executed on page changes #8
Comments
Now that that PR has been merged, there are a few minor changes that need to take place for this to work with regards to setting global variables. |
Okay, fixing this seems to be just about impossible until we can get the user's |
With #12 dealt with, this is now a single problem in the router, as a verdict is successfully generated, but for some reason Sycamore then doesn't run the logic to match that verdict and actually render a new page. This results in no exceptions and no identifiable error messages. |
With #2 closed and major changes to the app shell, this bug is now manifested in its third iteration: locale detection will call Sycamore's |
Okay, the new issue of not intercepting click events seems to be caused by the fact that the Sycamore router only handles click events for its children, and Perseus simply renders an empty template, hydrating to an element that the router doesn't control. I'll work on a fix for this now, and see what happens to the other part of this bug. |
Okay, we are back to one bug! Links now behave correctly as in an SPA, and now it's just that the closure passed to |
Links now behave correctly, but are still subject to #8.
Thank you @lukechu10 for all your help on this one! Greatly appreciated! |
This is a tracking issues for a series of bugs in Perseus related to the custom routing systems.
These bugs are all to do with the way Sycamore currently handles its
ContextProvider
system (detailed here), and they should all be fixed by this PR in Sycamore, which will be released shortly with Sycamore v0.6.0.After that, those updates will be integrated into Perseus for v0.2.0, and this issue should then be closable. This primarily exists to forewarn anyone who has decided to compile the
main
branch and is experiencing these issues.The text was updated successfully, but these errors were encountered: