-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove magic #151
Merged
Merged
Remove magic #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No support for serving yet and there's still Wasm binary bloat.
Still a lot of Wasm binary bloat.
This is untested as yet, I'll update the CLI first.
This is still untested because of a Cargo dependency unification issue.
This is literally dark magic.
Also changed the `run_dflt_engine` and `run_client` APIs to make them all take functions that return apps, rather than apps directly, which makes the Actix Web integration able to work normally (by making everything else share its quirks).
This feature is the default though.
Except `fetching`, need to merge from `main`.
Just made the user's functions `pub` to stop the compiler whining.
arctic-hen7
force-pushed
the
feat-remove-magic
branch
from
June 14, 2022 10:28
ea7c7be
to
7bbb911
Compare
There's now an `EXAMPLE_INTEGRATION` environment variable that controls this, which is set to `warp` by default in a new `.env` file, which Bonnie can read.
This also adds a `build_paths` macro to make that work with the new systems.
This made it uncompilable because of the silly way I've set that up. I'll fix that as I rewrite the docs for v0.4.0.
For completeness, I'm just going to note here that two days ago there was a bug in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the
.perseus/
directory entirely and make Perseus a lot more sensible for users not acquainted with its innards. This will also add full support for user modification of the builder and server code, finally adding support for custom API routes!Breaking Changes Tracker
EngineError
type now)HOST
andPORT
environment variables for configuring the server (these are replaced withPERSEUS_HOST
andPERSEUS_PORT
)#[autoserde(...)]
macro with macros for each state function (#[build_state]
,#[build_paths]
, etc.)#[build_paths]
macro must now be applied to all build paths functions (for client/server functionality division)#[perseus::main]
now takes an argument as the default server to use (server integrations should now be imported and used)#[cfg(not(feature = "wasm32"))]
#[should_revalidate]
macro must now be applied to all revalidation determination functions (for client/server functionality division)